[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 24 12:28:40 PDT 2021


mstorsjo added a comment.

In D111952#3068680 <https://reviews.llvm.org/D111952#3068680>, @mstorsjo wrote:

> I guess a downside of this solution, is that if an `i686` sysroot exists next to the clang binary, it becomes practically impossible to test codegen differences when you run it with various `-target iX86-w64-mingw32` options, as they'd all be corrected back to `i686`. (This wouldn't be an issue if the autodetection was done in `computeTargetTriple` only when the `-m32`/`-m64` options are used though.)

Ok, it turned out to not be that bad to move the fixup into `computeTargetTriple` to this location after all, it looks fairly neat and not that much out of line compared to the existing triple tweaks done there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111952/new/

https://reviews.llvm.org/D111952



More information about the cfe-commits mailing list