[PATCH] D109632: [clang] de-duplicate methods from AST files

Thu Oct 21 17:40:50 PDT 2021

vsapsai added a comment.

In D109632#3079455 <https://reviews.llvm.org/D109632#3079455>, @rmaz wrote:

> So given these numbers are we good to go ahead with set dedupe approach?

I'd rather get an opinion on this from other reviewers. It's not purely a numbers game, there can be other reasons to prefer one solution over another. I am biased, so I don't think I can make this call. If reviewers want a short summary instead of checking the entire discussion, we can prepare that.

If anybody is interested in the raw measurement data, I can provide it. The data is suitable for calculating the statistical significance between different methods using t-test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109632/new/

https://reviews.llvm.org/D109632