[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

ntfshard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 21 07:12:20 PDT 2021


ntfshard added a comment.

It seems I faced with degradation in compile time.



================
Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:68
+    return hash_value(
+        std::pair<unsigned, unsigned>(Tag.getDevice(), Tag.getFile()));
+  }
----------------
In this line a narrow conversion, and MSVC compiler can't build it with warnings as error key. 
getDevice and getFile returns uint64_t but pair expects unsigned ints.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110925/new/

https://reviews.llvm.org/D110925



More information about the cfe-commits mailing list