[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

[stan li via cfe-commits]

Hi Alex,
I’ll take a look. Not sure how long it takes though.
Please revert it. I don’t have the permission to commit yet.

Could you share more information about the crash?
What is the command line to repro the crash and which environment it crashed.

Thanks
Xiang
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows

From: Alexander Kornienko via Phabricator<mailto:reviews at reviews.llvm.org>
Sent: Wednesday, October 20, 2021 2:19 PM
To: python3kgae at outlook.com<mailto:python3kgae at outlook.com>; mizvekov at gmail.com<mailto:mizvekov at gmail.com>; blitzrakete at gmail.com<mailto:blitzrakete at gmail.com>; notstina at gmail.com<mailto:notstina at gmail.com>; shenhan at google.com<mailto:shenhan at google.com>; richard at metafoo.co.uk<mailto:richard at metafoo.co.uk>; bhuvanendra.kumarn at amd.com<mailto:bhuvanendra.kumarn at amd.com>; mlekena at skidmore.edu<mailto:mlekena at skidmore.edu>; jlerouge at apple.com<mailto:jlerouge at apple.com>; chris.bieneman at me.com<mailto:chris.bieneman at me.com>; aaron.ballman at gmail.com<mailto:aaron.ballman at gmail.com>
Cc: alexfh at google.com<mailto:alexfh at google.com>; ndesaulniers at google.com<mailto:ndesaulniers at google.com>; cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>; david.green at arm.com<mailto:david.green at arm.com>; ruiling.song at amd.com<mailto:ruiling.song at amd.com>
Subject: [PATCH] D111109: AddGlobalAnnotations for function with or without function body.

alexfh added a comment.

Reduced test case:

  template <class a> void b(a);
  template <typename c> class d {
  public:
    class e {
    public:
      c *f();
    };
    e *g();
  };
  template <class> class j;
  template <class h, class... i> class j<h(i...)> {
  public:
    class k {
    public:
      k(int *);
      ~k();
    };
    int n();
    d<int *> l;
  };
  template <class h, class... i> int j<h(i...)>::n() {
    auto m = l.g()->f();
    k a(*m);
    b(a);
  }
  template <class h, class... i>
  j<h(i...)>::k::~k() __attribute__((annotate(""))) {}
  class o {
    int m_fn4();
    j<int()> p;
  };
  int o::m_fn4() { p.n(); }

Please revert the commit if there is no quick and obvious solution. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111109/new/

https://reviews.llvm.org/D111109

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211020/e4f0242a/attachment.html>