[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 20 23:59:58 PDT 2021


balazske marked 4 inline comments as done.
balazske added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:6189
+  // Check if the import was correct.
+  CXXConstructorDecl *ToCtor = *ToL->ctor_begin();
+  const auto *ToFPT = ToCtor->getType()->getAs<FunctionProtoType>();
----------------
steakhal wrote:
> Please assert that the number of constructors is correct.
> I would rather recommend doing so in the //from// case as well.
Here the goal is only to get a copy constructor, not to test if all constructors are imported. To get the constructor count relatively much additional code is needed (there is no function for it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112013/new/

https://reviews.llvm.org/D112013



More information about the cfe-commits mailing list