[PATCH] D110287: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.

Wed Oct 20 17:44:38 PDT 2021

vsapsai added a comment.

In D110287#3075590 <https://reviews.llvm.org/D110287#3075590>, @dblaikie wrote:

> In D110287#3074175 <https://reviews.llvm.org/D110287#3074175>, @vsapsai wrote:
>
>> What would be a better way to deal with changes in areas where I'm more experienced in (Obj-C decl merging on AST deserialization) and still want to run pre-merge checks on other platforms? I got unofficial sign-offs internally but people defer to me because I've worked more in this area.
>
> Oh, sure - you can use Phabricator's draft support to just send the change for CI testing without sending a review to the mailing list: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line

D'oh, haven't realized that. Thanks for the advice!

>> I believe this change is pretty trivial, while for D110452 <https://reviews.llvm.org/D110452> I want another opinion. But one-line change in D110453 <https://reviews.llvm.org/D110453> is trivial too and I don't think that waiting for reviews for half a year would improve its quality substantially.
>
> Reviews shouldn't/generally don't take half a year, especially for smaller, clearly correct changes. Pinging reviews if they're not getting traction can help get some attention, though sometimes more direct calls for assistance may be necessary/beneficial.

Thanks, appreciate the advice. It is a sore subject for me, so I'll refrain from digging myself a deeper hole.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110287/new/

https://reviews.llvm.org/D110287