[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions
Balázs Benics via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 20 02:44:21 PDT 2021
steakhal added a comment.
I think it's fine, maybe `NFCi` is would be slightly more accurate, while stating the minor behavior change and the reason for doing so in the patch summary could further improve the visibility of this issue.
That being said, since it actually changes some behavior, I'd like to request some tests covering the following (uncovered lines):
L1646, L1689, L1699
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106681/new/
https://reviews.llvm.org/D106681
More information about the cfe-commits
mailing list