[PATCH] D110287: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.
David Blaikie via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 19 16:41:44 PDT 2021
dblaikie added a comment.
In D110287#3073804 <https://reviews.llvm.org/D110287#3073804>, @vsapsai wrote:
> Pre-merge checks are passing now after the rebase. I believe it is a straightforward change and we are merging decl contexts for other Decls already, so merging them for `ObjCInterfaceDecl` makes sense. If there are no objections, I plan to land the change on Friday, October 22. If any issues come up later, post-commit reviews are welcome as always.
Generally this sort of "if no one says anything I'll commit at this time" thing is to be avoided: The idea is that once something's been sent for review/the author has requested a second opinion, we want to avoid people committing that code without review only due to lack of feedback. Please reach out to reviewers to get a second set of eyes on this before committing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110287/new/
https://reviews.llvm.org/D110287
More information about the cfe-commits
mailing list