[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

The standard answer is that compilers are designed to work with a specific set of system headers.  In the Clang-on-Windows case, that's complicated by the fact that many people acquire Clang separately from the rest of the build environment (although Microsoft does distribute Clang officially now, right?), but I think the standard answer is still ultimately the correct one: Clang is designed to support the MSVC system headers that are currently out in the world, and whenever Microsoft releases new system headers, it's possible that you will need a new version of Clang.

As an aside, it's unfortunate that the name of this define makes it sound like not defining it implies that the environment is not concurrent.   Oh well; if the standard says it's tied to the header, then obviously it's right to not define it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112081/new/

https://reviews.llvm.org/D112081