[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

Actually, `cpplint` is never compatible with `clang-tidy` regardless. The following code:

  struct Foo
  {
  	Foo(int) {} // NOLINT(google-explicit-constructor)
  };

Triggers:

  ../test.cpp:3:  Unknown NOLINT error category: google-explicit-constructor  [readability/nolint] [5]

So one has to disable the diagnostic anyway via `--filter=-readability/nolint`. I've tested using globs and cpplint works fine so long the diagnostic is suppressed. I.e. this patch doesn't change things in that respect.

I go ahead and merge if you are happy then!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111208/new/

https://reviews.llvm.org/D111208