[PATCH] D111534: [analyzer][NFC] Refactor CallEvent::isCalled()

[Denys Petrov via Phabricator via cfe-commits]

ASDenysPetrov added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1289
+  /// E.g. { "std", "vector", "data" } -> "vector", "std"
+  auto begin_qualified_name_parts() const {
+    return std::next(QualifiedName.rbegin());
----------------
steakhal wrote:
> ASDenysPetrov wrote:
> > What rules did you use to name this functions? It seems that it goes against [[ https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly | LLVM naming rules]].
> Not exactly. There is an exception for `begin()` and `end()`.
> That being said, `begin` should have been a suffix instead of being a prefix.
> But I still like this more :D
Oh, now I see the exception. I also prefer `begin` as a prefix because it makes better search through the popup hints of IDEs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111534/new/

https://reviews.llvm.org/D111534