[PATCH] D112001: [Clang] Add min/max reduction builtins.

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 18 11:28:36 PDT 2021


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:16673
+  if (!VecTy)
+  if (!TyA->getAs<VectorType>())
+      return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2)
----------------
craig.topper wrote:
> Is this indented incorrectly? There appear to be 2 ifs at the same level
Yes they were, thanks! The `if (!TyA->getAs<VectorType>())` was a left-over from an earlier iteration. Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112001/new/

https://reviews.llvm.org/D112001



More information about the cfe-commits mailing list