[PATCH] D111993: [libomptarget][WIP] Patch amdgpu DeviceRTL until it compiles

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 18 07:43:28 PDT 2021


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:87
+#if 0
+// Can't spell the dispatch from runtime ordering like:
+template <int Ordering>
----------------
Suggestion offline is that delaying the check in clang for these builtins until template instantiation would make them usable from a function template, worthwhile usability improvement


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111993/new/

https://reviews.llvm.org/D111993



More information about the cfe-commits mailing list