[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=<n>+ syntax to mean no maximum vscale

[Matt D. via Phabricator via cfe-commits]

Matt added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1832
+      else {
+        assert(!Val.getAsInteger(10, Bits));
+        CmdArgs.push_back(
----------------
There may be a way to avoid side-effects in assertions (`getAsInteger` changing the value of `Bits` passed by reference) similarly to the `NewToSet` example in https://llvm.org/docs/CodingStandards.html#assert-liberally, similarly to https://github.com/llvm/llvm-project/blob/release/13.x/llvm/include/llvm/TableGen/Record.h#L1980-L1983 or https://github.com/llvm/llvm-project/blob/release/13.x/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp#L181-L185.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111790/new/

https://reviews.llvm.org/D111790