[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

Cyndy Ishida via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 15 08:30:20 PDT 2021


cishida added a comment.

In D111468#3066820 <https://reviews.llvm.org/D111468#3066820>, @jansvoboda11 wrote:

> LGTM.
>
> As a follow-up, do you think it would make sense to improve the documentation/comments around "index header maps"? Variable names refer to indexing while the documentation talks about building frameworks, which is confusing without referring back to the original Radar.

Makes sense to me. If I understand correctly, the headermap kind was introduced to work around a task generation limitation in Xcode which no longer is an issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111468/new/

https://reviews.llvm.org/D111468



More information about the cfe-commits mailing list