[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

Additionally to my previous observation, a surprising amount of the new findings are of `deadcode` detections, and most of them there are loops.

Other than that, I've seen a true-positive report as well:
F19624854: image.png <https://reviews.llvm.org/F19624854>
At line 'A', on the path where `valid_modulus` is assumed to be `true`, we now correctly constrain `spec->modulus` to zero. The only problem is that we never mention this in the bugreport xD
That being said, I would recommend introducing a bug-report visitor to complement this surprising behavior, OR somehow add a NoteTag to this transition where this operation gets evaluated.

I suspect we will need to tune the trackExpressionValue stuff to keep up, whenever we extend `ConstraintAssignor`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110357/new/

https://reviews.llvm.org/D110357