[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

John Ericson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 15 05:30:27 PDT 2021


Ericson2314 marked an inline comment as done.
Ericson2314 added a comment.

Respond to last open thing



================
Comment at: llvm/CMakeLists.txt:589
     CACHE STRING "Doxygen-generated HTML documentation install directory")
-set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html"
+set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}/ocaml-html"
     CACHE STRING "OCamldoc-generated HTML documentation install directory")
----------------
Ericson2314 wrote:
> Ericson2314 wrote:
> > compnerd wrote:
> > > Why the change from `llvm` -> `${project}`?  (not that it really makes a difference)
> > To be honest, I forgot. I might have just been OCD deduping on the fly. Happy to change back,
> Which would you like me to do, @compnerd?
Erred on the size of caution and put it back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100810/new/

https://reviews.llvm.org/D100810



More information about the cfe-commits mailing list