[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

After more than 1 week without comments, I kindly ping reviewers @mgartmann @aaron.ballman  @hokein @whisperity @njames93 to have a look and see if we can merge or is there something I should address. I have posted a question about Sema in cfe-dev, but didn't get any reply. I know the current solution is not ideal but at least it add tests and solves the problem. I'm happy to bring back a more "idiomatic" solution once the Sema issue has been investigated and solved (which could take a while).

Thanks a lot!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110614/new/

https://reviews.llvm.org/D110614