[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

This seems like two places this was missed in: https://reviews.llvm.org/D63960 however I see a another place grepping around we might have missed too?  Can you find a way to write tests for that?

Also, perhaps 1 more cleanup?



================
Comment at: clang/lib/Sema/SemaOverload.cpp:13800
 
         ExprResult R = MaybeBindToTemporary(TheCall);
         if (R.isInvalid())
----------------
Wonder if as a 'while we're here' we should make this the same as the others? Does `CheckForImmediateInvocation` handle an invalid result without the extra check like we have here?


================
Comment at: clang/lib/Sema/SemaOverload.cpp:14290
 
     return MaybeBindToTemporary(call);
   }
----------------
Was this one missed too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111817/new/

https://reviews.llvm.org/D111817