[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment
Balázs Benics via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 14 06:23:01 PDT 2021
steakhal added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2126-2130
+ // Initiate the reorganization of the equality information. E.g., if we
+ // have `c + 1 == 0` then we'd like to express that `c == -1`. It makes
+ // sense to do this only with `SymIntExpr`s.
+ // TODO Handle `IntSymExpr` as well, once computeAdjustment can handle
+ // them.
----------------
Can the simplification of a `SymSymExpr` result in `IntSymExpr`? If it can happen, then we could see such instances and we should do the right thing with them as well.
WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111642/new/
https://reviews.llvm.org/D111642
More information about the cfe-commits
mailing list