[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 13 12:21:04 PDT 2021


mstorsjo added a comment.

In D111707#3062361 <https://reviews.llvm.org/D111707#3062361>, @MaskRay wrote:

> I was thinking of when testing "windows" x "pic", whether the test should reside in "windows" or "pic".
> If in "windows", we can decrease the number of RUN lines and use one RUN line to test multiple properties at one time.
> If in "pic", it does make it clear what platforms default to pic but I think many platforms have dedicated tests and duplicate the coverage here anyway.

True, but then again, this avoids needing to duplicate the PIC level checks across two files. It costs a couple more `RUN` lines, true...

Anyway, I'm not strongly opposed to restructuring it, but feel free to pick that up as a followup if you want to - I'd rather keep this one as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111707/new/

https://reviews.llvm.org/D111707



More information about the cfe-commits mailing list