[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 13 12:06:42 PDT 2021


mstorsjo added inline comments.


================
Comment at: clang/test/Driver/pic.c:322
 // RUN:   | FileCheck %s --check-prefix=CHECK-PIC2
+// RUN: %clang -c %s -target aarch64-windows-msvc -### 2>&1 \
+// RUN:   | FileCheck %s --check-prefix=CHECK-PIC2
----------------
MaskRay wrote:
> perhaps change windows-pic.cpp instead
That file actually doesn't test the thing that this patch touches (if I remove the existing cases for `x86_64` in the modified functions, that test still passes but this one breaks), so I thought this one is a better fit, wrt what the test actually tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111707/new/

https://reviews.llvm.org/D111707



More information about the cfe-commits mailing list