[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

[Evgenii Stepanov via Phabricator via cfe-commits]

eugenis added a comment.

Right, but a cache for SanitizerArgs is not enough to avoid repeated diagnostics, is it? Ex. if I request a non-existing sanitizer, I think I would get errors from host arg parsing, as well as from each of device1 and device2, because each device will have a unique ArgList.

Is it even possible for the driver to introduce new diagnostics in offload SanitizerArgs parsing? Is it possible to catch those cases ahead of time, when parsing SanitizerArgs for the first time, by looking at a target triple or something? That would be the most user friendly approach.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111443/new/

https://reviews.llvm.org/D111443