[PATCH] D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 13 09:31:40 PDT 2021


aaron.ballman closed this revision.
aaron.ballman added a comment.

In D111625#3061736 <https://reviews.llvm.org/D111625#3061736>, @Sockke wrote:

> In D111625#3060978 <https://reviews.llvm.org/D111625#3060978>, @aaron.ballman wrote:
>
>> LGTM, thank you! Do you need me to commit on your behalf? I'm happy to do so, but given the number of quality submissions you've had, I'm wondering if you'd like to obtain commit access of your own? (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access has the details of what that entails.)
>
> Thanks a lot! It's my pleasure to obtain commit access of my own. I will send the application as required later. Before that, I would appreciate it if you could commit it on my behalf. Thanks again! 
> Name: liuke
> Email: liuke.gehry at bytedance.com

Sounds great! I've commit on your behalf in ea72b55b5c7c281cb21bb7bd50e6e039ca63dfe8 <https://reviews.llvm.org/rGea72b55b5c7c281cb21bb7bd50e6e039ca63dfe8>, thank you for the fix!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111625/new/

https://reviews.llvm.org/D111625



More information about the cfe-commits mailing list