[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Wed Oct 13 07:22:24 PDT 2021

bader added inline comments.

================
Comment at: clang/lib/Sema/SemaSYCL.cpp:45
+  /// accessor class.
+  static bool isSyclAccessorType(const QualType &Ty);
+
----------------
erichkeane wrote:
> Isn't there a big rewrite going on downstream of these with `sycl_special_class`?  Why are we trying to upstream this before that happens?
> Isn't there a big rewrite going on downstream of these with `sycl_special_class`?  

Yes.

> Why are we trying to upstream this before that happens?

The downstream work was initiated by this comment: https://reviews.llvm.org/D71016#inline-644645.
This patch was uploaded for review here before refactoring work has started.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71016/new/

https://reviews.llvm.org/D71016