[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:12798
+  /// Access to SYCL kernels.
+  SmallVectorImpl<Decl *> &getSYCLKernels() { return SYCLKernels; }
+
----------------
`ArrayRef<Decl *> getSYCLKernels()`


================
Comment at: clang/lib/Sema/SemaSYCL.cpp:90
+
+class KernelBodyTransform : public TreeTransform<KernelBodyTransform> {
+public:
----------------
`final`


================
Comment at: clang/lib/Sema/SemaSYCL.cpp:115
+/// Return method by name
+CXXMethodDecl *getMethodByName(const CXXRecordDecl *CRD, StringRef MethodName) {
+  CXXMethodDecl *Method;
----------------
Make functions `static`?


================
Comment at: clang/lib/Sema/SemaSYCL.cpp:117
+  CXXMethodDecl *Method;
+  auto It = std::find_if(CRD->methods().begin(), CRD->methods().end(),
+                         [MethodName](const CXXMethodDecl *Method) {
----------------
`llvm::find_if`


================
Comment at: clang/lib/Sema/SemaSYCL.cpp:186
+template <> struct bind_param<CXXBaseSpecifier &> {
+  using type = const CXXBaseSpecifier &;
+};
----------------
`Type`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71016/new/

https://reviews.llvm.org/D71016