[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 13 00:25:47 PDT 2021


nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

Thanks for fixing this!



================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:351
+  EXPECT_DECLS("TemplateArgumentLoc", {"template <typename> class ...T"});
+  Flags.clear();
+
----------------
The `Flags.clear()` in the previous cases is a leftover from when we used to do `Flags = {"-fno-delayed-template-parsing"};` to get the test to pass on Windows. That has since been removed (it's set directly by `TestTU`), so the `Flags.clear()` is no longer necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111648/new/

https://reviews.llvm.org/D111648



More information about the cfe-commits mailing list