[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

[Balázs Benics via Phabricator via cfe-commits]

steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

Excellent! All lines are covered.
Great job.



================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1619
+      return true;
+    const SymExpr *LHS = Sym->getLHS();
+    const llvm::APSInt &Zero =
----------------
martong wrote:
> ASDenysPetrov wrote:
> > steakhal wrote:
> > > 
> > Since `SymbolRef` actually is already `const`. (`using SymbolRef = const SymExpr *;`)
> Fair enough.
They mean different things. What I wanted is to declare both the pointer and the pointee `const`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110357/new/

https://reviews.llvm.org/D110357