[PATCH] D107944: [hmaptool] Port to python3

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 12 18:38:22 PDT 2021


bruno added a comment.

Overall looks great but there are some test failures, looks like you also need to update line 223?

  --
  Traceback (most recent call last):
    File "/var/lib/buildkite-agent/builds/llvm-project/build/bin/hmaptool", line 296, in <module>
      main()
    File "/var/lib/buildkite-agent/builds/llvm-project/build/bin/hmaptool", line 293, in main
      commands[cmd](cmd, sys.argv[2:])
    File "/var/lib/buildkite-agent/builds/llvm-project/build/bin/hmaptool", line 223, in action_write
      f.write(magic.encode())
  AttributeError: 'bytes' object has no attribute 'encode'
  --


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107944/new/

https://reviews.llvm.org/D107944



More information about the cfe-commits mailing list