[PATCH] D111665: [CUDA] Provide address space conversion builtins.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 12 12:27:12 PDT 2021


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Not loving the magic constants here but I don't think we have a enum or similar right now.
I also have to question the people that choose `size_t` here... we will end up with int2ptr(ptr2int(...)) IR everywhere if this is actually used (outside the asm uses in cuda).
Anyway, LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111665/new/

https://reviews.llvm.org/D111665



More information about the cfe-commits mailing list