[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 12 10:08:09 PDT 2021


carlosgalvezp added a comment.

Thanks a lot for the review and the help!

By the way, should we keep the [clang-tidy] header for the next commits? Glancing at the commit history, I think it's much easier to see what the commit is updating, and probably can setup email filters to only receive notifications e.g. when [clang-tidy] is in the commit message. It's also consistent with the rest of commits. For example this one:

https://github.com/llvm/llvm-project/commit/a76cfc2e840ff373b80e3a5f84fc48c5f1f90d8a


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111041/new/

https://reviews.llvm.org/D111041



More information about the cfe-commits mailing list