[PATCH] D111199: [POC][BTF] support btf_type_tag attribute
Yonghong Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 11 13:01:28 PDT 2021
yonghong-song added inline comments.
================
Comment at: clang/include/clang/AST/Type.h:4768
+private:
+ std::string BTFTypeTag;
+
----------------
aaron.ballman wrote:
> I think we should be able to use a `StringRef` instead, rather than have to worry about allocations.
StringRef indeed works as a type. Previously, I used StringRef directly passed by the caller but later the underlying string is somehow freed so I got a "" string for tag. I will revisit this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111199/new/
https://reviews.llvm.org/D111199
More information about the cfe-commits
mailing list