[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

[Dave Green via Phabricator via cfe-commits]

dmgreen added a comment.

Thanks for the updates.

In D109825#3055264 <https://reviews.llvm.org/D109825#3055264>, @lenary wrote:

> In D109825#3055142 <https://reviews.llvm.org/D109825#3055142>, @xgupta wrote:
>
>> It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support).
>
> I'm not convinced this is required - those tests are to ensure that the extensions (rcpc, dotprod) can be enabled either from a `-march`, or from a `-mcpu=<cpu>` with a cpu that contains that extension -- they are not testing that the extension is enabled from *all* cpus that contain said extension.

Yeah I agree. It would be useful to add some tests for -mcpu=cortex-a510+crypto and -mcpu=cortex-a510+nocrypto, to make sure they do what is expected.



================
Comment at: clang/docs/ReleaseNotes.rst:86
 
+- Support has been added for the following processors (command-line identifiers in parentheses):
+  - Arm Cortex-A510 (cortex-a510)
----------------
Can you add an Arm section below and move this to it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109825/new/

https://reviews.llvm.org/D109825