[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

Sam Elliott via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 11 08:42:07 PDT 2021


lenary added a comment.

In D109825#3055142 <https://reviews.llvm.org/D109825#3055142>, @xgupta wrote:

> It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support).

I'm not convinced this is required - those tests are to ensure that the extensions (rcpc, dotprod) can be enabled either from a `-march`, or from a `-mcpu=<cpu>` with a cpu that contains that extension -- they are not testing that the extension is enabled from *all* cpus that contain said extension.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109825/new/

https://reviews.llvm.org/D109825



More information about the cfe-commits mailing list