[PATCH] D111457: [clang][test] Add lit helper for windows paths

Keith Smiley via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 8 16:34:38 PDT 2021


keith added inline comments.


================
Comment at: clang/test/lit.cfg.py:60
+if platform.system() == 'Windows':
+    root_sep = 'C:\\'
+else:
----------------
rmaz wrote:
> `c:\`?
Do you mean lowercase or a single slash? I see ~2x the number of uppercase vs lowercase in this codebase now, and the second is just because of escaping


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111457/new/

https://reviews.llvm.org/D111457



More information about the cfe-commits mailing list