[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

Victor Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 8 10:38:40 PDT 2021


NeHuang added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-error.c:46
   unsigned int mask;
-  unsigned int res = __builtin_ppc_rlwnm(ui, shift, 7); // expected-error {{argument to '__builtin_ppc_rlwnm' must be a constant integer}}
+  unsigned int res = __builtin_ppc_rlwnm(ui, shift, 7);
   res = __builtin_ppc_rlwnm(ui, 31, mask);              // expected-error {{argument to '__builtin_ppc_rlwnm' must be a constant integer}}
----------------
Please also remove `__builtin_ppc_rlwnm(ui, shift, 7);` in this test. We only keep cases trigger sema check errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111229/new/

https://reviews.llvm.org/D111229



More information about the cfe-commits mailing list