[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

Freddy, Ye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 8 06:49:43 PDT 2021


FreddyYe added inline comments.


================
Comment at: clang/test/Misc/target-invalid-cpu-note.c:1
+// Use CHECK-NEXT instead of CHECK-SAME: ensure outputs between different lines of CHECK-SAME not missing checked.
 // RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM
----------------
DavidSpickett wrote:
> This wording is a bit confusing, how about:
> // Use CHECK-NEXT instead of multiple CHECK-SAME to ensure we will fail if there is anything extra in the output
Looks better. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110798/new/

https://reviews.llvm.org/D110798



More information about the cfe-commits mailing list