[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 8 05:42:00 PDT 2021


sammccall accepted this revision.
sammccall added a comment.

Nice!



================
Comment at: clang/docs/tools/dump_ast_matchers.py:48
   text = re.sub(r'>', '>', text)
   def link_if_exists(m):
     name = m.group(1)
----------------
While here I'd add a comment:
```
"""
Wrap a likely AST node name in a link to its clang docs.

We want to do this only if the page exists, in which case it will be referenced from the class index page.
"""
```

(You're only adding a bit of conceptual complexity here, but it looks like it's been built up over time...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111332/new/

https://reviews.llvm.org/D111332



More information about the cfe-commits mailing list