[PATCH] D111391: [NFC] [Clang] Use global enum for explicit float mode
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 8 04:38:17 PDT 2021
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the cleanup!
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4209
ComplexMode = false;
+ ExplicitType = FloatModeKind::NoFloat;
switch (Str.size()) {
----------------
This bit looks like it's not an NFC change -- we never used to set this value before. However, it is an NFC change because the caller always sets `ExplicitType` to `NoFloat`, so this is more for safety when adding new callers, which is fine by me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111391/new/
https://reviews.llvm.org/D111391
More information about the cfe-commits
mailing list