[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

James King via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 7 16:09:55 PDT 2021


jcking1034 added inline comments.


================
Comment at: clang/docs/tools/dump_ast_matchers.py:13
 
+CLASS_INDEX_PAGE = urlopen("https://clang.llvm.org/doxygen/classes.html").read()
+
----------------
aaron.ballman wrote:
> Do we need to handle an exception here if there are network issues?
Technically, if there is a network issue, any exceptions would cause the script to terminate. But I think you're right that we should handle this case more carefully.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111332/new/

https://reviews.llvm.org/D111332



More information about the cfe-commits mailing list