[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

> CodeGenFunction::InitTempAlloca() inits the static alloca within the entry block which may *not* necessarily be correct always.

FWIW, for all uses this was correct. The point of the function was exactly to do what you state here as "potentially incorrect".
The documentation explicitly states "and the initializer must be valid in the entry block (i.e. it must either be a constant or an argument value)."
The rest of the reasoning that follows for this patch is consequently mood.

While I don't expect this to have a real negative impact on performance it certainly could if we are somewhat sensitive to the additional stores that
are now executed prior to an event which requires a temporary storage location (in OpenMP).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111293/new/

https://reviews.llvm.org/D111293