[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 7 14:39:50 PDT 2021


rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjC.cpp:2351
 
-  // FIXME: Do this when the target isn't aarch64.
+  llvm::Triple::ArchType Arch = CGF.CGM.getTriple().getArch();
+
----------------
Please leave a comment saying that we should do this on all targets, and the limiting factor is that it needs specific support from the backend.

Otherwise, this patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111331/new/

https://reviews.llvm.org/D111331



More information about the cfe-commits mailing list