[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 6 21:36:24 PDT 2021
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Patch looks good to me now, thanks. I don't think `always_inline` should strictly be necessary vs. just `static inline`, because in either case the function definition containing the non-canonical ivar reference is emitted in the same IRGen, which is what's triggering the assertion. But it's all the same to the test case, and I have no objections to using `always_inline`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110280/new/
https://reviews.llvm.org/D110280
More information about the cfe-commits
mailing list