[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

Yonghong Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 6 17:58:52 PDT 2021


yonghong-song updated this revision to Diff 377727.
yonghong-song added a comment.

- Instead of piggyback on existing AttributedType, create a new child class AttributedBTFType. The code is reorganized to avoid intrusive to existing AttributedType.
- Hack: the AttributedBTFType still not trivially destructible. Haven't find a best way how to fix it.
- Missing: With AttributedBTFType, we need to handle more things, serialization/deserialization, TypeProperties, etc.

It would be good if I can get some feedback on the overall approach before diving into more details.
cc @aaron.ballman


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111199/new/

https://reviews.llvm.org/D111199

Files:
  clang/include/clang/AST/ASTContext.h
  clang/include/clang/AST/Type.h
  clang/include/clang/Basic/Attr.td
  clang/lib/AST/ASTContext.cpp
  clang/lib/AST/TypePrinter.cpp
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/lib/Sema/SemaType.cpp
  clang/test/CodeGen/attr-btf_type_tag-conv-var.c
  clang/test/CodeGen/attr-btf_type_tag-typedef-field.c
  clang/test/Sema/attr-btf_type_tag.c
  llvm/include/llvm/IR/DIBuilder.h
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  llvm/lib/IR/DIBuilder.cpp
  llvm/test/DebugInfo/attr-btf_type_tag.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111199.377727.patch
Type: text/x-patch
Size: 19218 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211007/c4a18b5b/attachment-0001.bin>


More information about the cfe-commits mailing list