[PATCH] D109632: [clang] de-duplicate methods from AST files

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

These are interesting results. I'm curious to measure the time spent in `ASTReader::ReadMethodPool`.

I'm planning to preserve the order of methods roughly by `s/InstanceMethods.append/InstanceMethods.prepend/` in `ReadMethodPoolVisitor`. `isAcceptableMethodMismatch` is fixable but "id" can have multiple methods applicable and existing source code relies on specific methods to be first in the methods' lists. Changing the order would break existing working code and we cannot afford that. Curious to see how the preserved order might impact the performance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109632/new/

https://reviews.llvm.org/D109632