[PATCH] D111267: [clang] Fix darwin REQUIRES test annotation (NFC)

Keith Smiley via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 6 13:30:29 PDT 2021


keith created this revision.
keith requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Some subprojects like compiler-rt define the `darwin` feature in their
lit config, but clang does not do that, so we need to use the global
`system-darwin` here instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111267

Files:
  clang/test/Driver/apple-arm64-arch.c
  clang/test/Driver/darwin-warning-options.c
  clang/test/Driver/mtargetos-darwin.c


Index: clang/test/Driver/mtargetos-darwin.c
===================================================================
--- clang/test/Driver/mtargetos-darwin.c
+++ clang/test/Driver/mtargetos-darwin.c
@@ -10,7 +10,7 @@
 // RUN: %clang -mtargetos=darwin20 -arch arm64 -c %s -o %t.o -### 2>&1 | FileCheck --check-prefix=INVALIDOS %s
 // RUN: %clang -mtargetos=ios -arch arm64 -c %s -o %t.o -### 2>&1 | FileCheck --check-prefix=NOVERSION %s
 
-// REQUIRES: darwin
+// REQUIRES: system-darwin
 
 // MACOS: "-cc1" "-triple" "arm64-apple-macosx11.0.0"
 // MACOS-NEXT: "-cc1" "-triple" "x86_64-apple-macosx11.0.0"
Index: clang/test/Driver/darwin-warning-options.c
===================================================================
--- clang/test/Driver/darwin-warning-options.c
+++ clang/test/Driver/darwin-warning-options.c
@@ -1,4 +1,4 @@
-// REQUIRES: darwin
+// REQUIRES: system-darwin
 
 // Always error about undefined 'TARGET_OS_*' macros on Darwin.
 // RUN: %clang -### %s 2>&1 | FileCheck %s
Index: clang/test/Driver/apple-arm64-arch.c
===================================================================
--- clang/test/Driver/apple-arm64-arch.c
+++ clang/test/Driver/apple-arm64-arch.c
@@ -1,7 +1,7 @@
 // RUN: env SDKROOT="/" %clang -arch arm64 -c -### %s 2>&1 | \
 // RUN:   FileCheck %s
 //
-// REQUIRES: darwin
+// REQUIRES: system-darwin
 // XFAIL: apple-silicon-mac
 //
 // CHECK: "-triple" "arm64-apple-ios{{[0-9.]+}}"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111267.377665.patch
Type: text/x-patch
Size: 1422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211006/2899df49/attachment.bin>


More information about the cfe-commits mailing list