[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

[Petr Hosek via Phabricator via cfe-commits]

phosek added inline comments.


================
Comment at: clang/lib/Basic/Targets/OSTargets.h:893
       Builder.defineMacro("_GNU_SOURCE");
+    Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel));
+    this->PlatformName = "fuchsia";
----------------
aaron.ballman wrote:
> I think this macro should be using a reserved name, as suggested by @phosek.
@aaron.ballman Do you have any thoughts on the letter case? I think that `__Fuchsia_API_level__` might be a better match for `__Fuchsia__`. Upper case is perhaps more usual, but other platforms like *BSD also use mixed case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108592/new/

https://reviews.llvm.org/D108592