[PATCH] D110781: [CUDA] Make sure <string.h> is included with original __THROW defined.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 6 06:28:52 PDT 2021


jdoerfert added a comment.

I first had to read up on pop_macro -.-. Still unsure if it is OK to push it once and pop it twice, that works fine?
Can't we move the string include earlier, grouped with stdlib and cmath? then we don't need to play with __THROW twice.
Other than that it seems sensible to let string have a __THROW, even though none of this mismatch is really sensible at the end of the day...

While we are here, we should be able to have a test, no? Something in string.h that depends on __THROW being present should suffice I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110781/new/

https://reviews.llvm.org/D110781



More information about the cfe-commits mailing list