[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin
Martin Storsjö via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 5 23:36:12 PDT 2021
mstorsjo added a subscriber: rnk.
mstorsjo added a comment.
This looks ok to me I guess. Technically in this case, this is pretty much equivalent to `#ifdef _WIN32`, i.e. any form when running on windows, where the process considers itself windows (cygwin doesn't define `_WIN32`), but I guess keeping it based on `getProcessTriple()` is fine too.
I'll leave it open for discussion for a while, but if there's no further opinions I can accept it later.
@rnk Do you happen to have any experience here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111195/new/
https://reviews.llvm.org/D111195
More information about the cfe-commits
mailing list