[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 5 22:56:50 PDT 2021


serge-sans-paille added a comment.

In D109967#3044464 <https://reviews.llvm.org/D109967#3044464>, @rnk wrote:

> Thanks for doing this, this approach looks like it incorporated my feedback on the previous approach.

Yeah, listened to the wise men... and struggled a lot doing so ;-)



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3177
+
   // PR9614. Avoid cases where the source code is lying to us. An available
   // externally function should have an equivalent function somewhere else,
----------------
rnk wrote:
> Can this trivially recursive builtin detection stuff be removed now? That would be great.
Let me give it a try!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109967/new/

https://reviews.llvm.org/D109967



More information about the cfe-commits mailing list